Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update CloudFormation resource spec to v2.29.0 #2170

Merged
merged 6 commits into from
Apr 4, 2019
Merged

feat: update CloudFormation resource spec to v2.29.0 #2170

merged 6 commits into from
Apr 4, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Apr 3, 2019 •
edited
Loading

See CHANGELOG for details (new AppMesh module).

Fixes to update scripts:

  • Fix typo "pytohn" to "python"
  • Enable re-running the update script in case of a failure
  • Update decdk dep list automatically

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

feat: update CloudFormation resource spec to v2.29.0
8716d4e 
See CHANGELOG for details (new AppMesh module).


Fixes to update scripts:

- Fix typo "pytohn" to "python"
- Enable re-running the update script in case of a failure
- Update decdk dep list automatically
@eladb eladb requested a review from a team as a code owner April 3, 2019 13:22
@eladb eladb requested a review from SoManyHs as a code owner April 3, 2019 18:06
SoManyHs
SoManyHs reviewed Apr 3, 2019
View reviewed changes
packages/@aws-cdk/cfnspec/build-tools/create-missing-libraries.ts
@@ -123,7 +123,7 @@ async function main() {
artifactId: javaArtifactId
}
},
pytohn: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REFERERERER

@eladb eladb merged commit ebc490d into master Apr 4, 2019
@eladb eladb deleted the benisrae/cfn-update branch April 4, 2019 13:12
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoManyHs SoManyHs SoManyHs approved these changes

@rix0rrr rix0rrr rix0rrr approved these changes

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eladb @RomainMuller @rix0rrr @SoManyHs @NGL321