Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@aws-cdk/cloudwatch] Revert custom DashboardName generation once CloudFormation bug is fixed #213

Closed
rix0rrr opened this issue Jul 2, 2018 · 0 comments · May be fixed by MechanicalRock/account-reaper#6
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jul 2, 2018

There is a bug in CloudFormation which cases Updates to an AWS::CloudWatch::Dashboard to fail if DashboardName was not supplied.

We now have a CDK-local workaround which will generate a name if the user didn't supply one.

Once the upstream bug is fixed, we should remove the workaround.

@debora-ito debora-ito added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Nov 7, 2018
piradeepk pushed a commit to piradeepk/aws-cdk that referenced this issue Apr 25, 2019
There was a bug in CloudFormation which caused updates to `AWS::CloudWatch::Dashboard` to fail if `DashboardName` was not supplied.

Now that the bug has been fixed we can revert the workaround in CDK which generates a name if the user doesn't supply one.

Fixes aws#213.
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this issue May 14, 2019
There was a bug in CloudFormation which caused updates to `AWS::CloudWatch::Dashboard` to fail if `DashboardName` was not supplied.

Now that the bug has been fixed we can revert the workaround in CDK which generates a name if the user doesn't supply one.

Fixes aws#213.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch
Projects
None yet
2 participants