Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AwsIntegration integrationHttpMethod hard coded to: POST ! #2105

Closed
ranguard opened this issue Mar 27, 2019 · 0 comments · Fixed by #2160 · May be fixed by MechanicalRock/account-reaper#6
Closed

AwsIntegration integrationHttpMethod hard coded to: POST ! #2105

ranguard opened this issue Mar 27, 2019 · 0 comments · Fixed by #2160 · May be fixed by MechanicalRock/account-reaper#6

Comments

@ranguard
Copy link
Contributor

I've been trying to fathom out why my gateway with a AWSIntergration to S3 kept making POST requests, not GET requests...

https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-apigateway/lib/integrations/aws.ts#L73

Please can this be resolved so I can set integrationHttpMethod (I'd patch, but not quite sure where this should actually sit from an interface perspective).
unstubbable added a commit to unstubbable/aws-cdk that referenced this issue Apr 2, 2019
@unstubbable
fix(aws-apigateway): add integrationHttpMethod prop to AwsIntegration
9492e43 
fixes aws#2105
unstubbable added a commit to unstubbable/aws-cdk that referenced this issue Apr 2, 2019
@unstubbable
fix(aws-apigateway): add integrationHttpMethod prop to AwsIntegration
dc8a688 
Allows a custom http method to be used for an AWS integration, using POST as default.

Fixes aws#2105
unstubbable added a commit to unstubbable/aws-cdk that referenced this issue Apr 2, 2019
@unstubbable
fix(aws-apigateway): add integrationHttpMethod prop to AwsIntegration
fd7bd41 
Allows a custom http method to be used for an AWS integration, using POST as default.

Fixes aws#2105
@unstubbable unstubbable mentioned this issue Apr 2, 2019
Merged
4 tasks
unstubbable added a commit to unstubbable/aws-cdk that referenced this issue Apr 3, 2019
@unstubbable
fix(aws-apigateway): add integrationHttpMethod prop to AwsIntegration
9d50dcd 
Allows a custom http method to be used for an AWS integration, using POST as default.

Fixes aws#2105
eladb pushed a commit that referenced this issue Apr 10, 2019
@unstubbable
fix(aws-apigateway): add integrationHttpMethod prop to AwsIntegration (…
dfc6665 
…#2160)

Allows a custom http method to be used for an AWS integration, using POST as default.

Fixes #2105
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ranguard