-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): add a newVersion
method
#2099
Conversation
* even though it traveled through the entire Pipeline, | ||
* because the Alias is still pointing to an old Version. | ||
* This method creates a new, unique Version every time the CDK code is executed, | ||
* and so prevents that from happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's up with the new-lines here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally try to break docs on sentence boundaries, so that future diffs of changes here will look better.
The newlines are not rendered in the docs themselves.
Is any of this visible to the user? Would they care? |
Yes. Yes. |
This method is useful when deploying a Lambda through a CodePipeline. It creates a new Version every time the CDK code is executed, that way making sure an updated Lambda Alias will not point to an old Version.
28f9e9b
to
1b5272d
Compare
Rebased and changed the method to use |
I kinda would hope we'd have a better solution than this (source hash, most likely), but until we do this'll do (pig). |
This method is useful when deploying a Lambda through a CodePipeline.
It creates a new Version every time the CDK code is executed,
that way making sure an updated Lambda Alias will not point to an old Version.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.