Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VpcNetwork): support reserved subnets in subnetConfiguration #2090

Merged
merged 8 commits into from
Apr 1, 2019

Conversation

darcoli
Copy link
Contributor

@darcoli darcoli commented Mar 26, 2019

Adds functionality to have reserved subnets which reserve a block of IP space within a VPC but do not actually provision any resources.

Closes #2087


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • __CLI change?: coordinate update of integration tests with team
    • __cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@darcoli darcoli requested a review from a team as a code owner March 26, 2019 00:41
@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 26, 2019

I think I'm in favor of a simpler solution, see the ticket for further discussion.

@rix0rrr rix0rrr self-assigned this Mar 26, 2019
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a simpler api

@RomainMuller RomainMuller added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Mar 28, 2019
@RomainMuller RomainMuller added the feature-request A feature should be added or improved. label Mar 28, 2019
@darcoli darcoli changed the title feat(VpcNetwork): support subnet groups in subnetConfiguration feat(VpcNetwork): support reserved subnets in subnetConfiguration Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot extend subnet groups properly after vpc is deployed
3 participants