Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cdk.Secret #2064

Closed
rix0rrr opened this issue Mar 21, 2019 · 0 comments · Fixed by #2068 · May be fixed by MechanicalRock/account-reaper#6
Closed

Remove cdk.Secret #2064

rix0rrr opened this issue Mar 21, 2019 · 0 comments · Fixed by #2068 · May be fixed by MechanicalRock/account-reaper#6
Labels
@aws-cdk/core Related to core CDK functionality pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 21, 2019

There's a vestigial Secret handling class which shouldn't be used anymore. Get rid of it.
@rix0rrr rix0rrr added pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version. @aws-cdk/core Related to core CDK functionality labels Mar 21, 2019
rix0rrr pushed a commit that referenced this issue Mar 21, 2019
fix(core): remove cdk.Secret
223774d 
`cdk.Secret` was left over from when we thought we were going to do
secrets differently. Today, we model secret values as strings, which
can be retrieved from one of these:

- `ssm.ParameterStoreSecureString.stringValue`
- `secretsmanager.SecretString.stringValue`
- `cdk.CfnParameter.stringValue` (but don't do that, because the secret
  will be readable from CloudFormation logs)

Fixes #2064.

BREAKING CHANGE: Replace use of `cdk.Secret` with
`secretsmanager.SecretString` (preferred) or
`ssm.ParameterStoreSecureString`.
@rix0rrr rix0rrr mentioned this issue Mar 21, 2019
Merged
4 tasks
rix0rrr added a commit that referenced this issue Apr 1, 2019
@rix0rrr
fix(core): remove cdk.Secret (#2068)
b53d04d 
`cdk.Secret` was left over from when we thought we were going to do
secrets differently. Today, we model secret values as strings, which
can be retrieved from one of these:

- `ssm.ParameterStoreSecureString.stringValue`
- `secretsmanager.SecretString.stringValue`
- `cdk.CfnParameter.stringValue` (but don't do that, because the secret
  will be readable from CloudFormation logs)

Fixes #2064.

BREAKING CHANGE: Replace use of `cdk.Secret` with
`secretsmanager.SecretString` (preferred) or
`ssm.ParameterStoreSecureString`.
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/core Related to core CDK functionality pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version.
Projects
None yet
Milestone
No milestone
1 participant
@rix0rrr