fix(cfn2ts): properly deTokenize string[] #2033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of accepted Tokenized values, cfn2ts previously translated a
string and string array into:
The latter was not intended. We now emit:
Since the Token will be typed as
Object
in Java, this change now makesit impossible to mistakenly pass any old java Object. A typical case
would be pass a
Subnet
where astring subnetId
was expected, failingin a nonobvious way.
Fixes #2030.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.