-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java Error TransitGateway new Attachment #2030
Closed
evildani opened this issue
Mar 17, 2019
· 3 comments
· Fixed by #2033 · May be fixed by MechanicalRock/account-reaper#6
Closed
Java Error TransitGateway new Attachment #2030
evildani opened this issue
Mar 17, 2019
· 3 comments
· Fixed by #2033 · May be fixed by MechanicalRock/account-reaper#6
Comments
I'd have a suspicion the problem is in this line: .withSubnetIds(Arrays.asList(vpc1.getPublicSubnets().get(0))) SubnetIds requires a list of strings, and you're giving a list of subnet objects. The problem is we're still accepting |
Aha, here is the issue:
|
rix0rrr
added a commit
that referenced
this issue
Mar 18, 2019
Because of accepted Tokenized values, cfn2ts previously translated a string and string array into: interface Props { someString: string; stringArray: Array<string | Token> | Token; } The latter was not intended. We now emit: interface Props { someString: string; stringArray: string[]; } Since the Token will be typed as `Object` in Java, this change now makes it impossible to mistakenly pass any old java Object. A typical case would be pass a `Subnet` where a `string subnetId` was expected, failing in a nonobvious way. Fixes #2030.
4 tasks
Correct, the subnet id should be a string and not a subnet object. |
rix0rrr
added a commit
that referenced
this issue
Mar 18, 2019
Because of accepted Tokenized values, cfn2ts previously translated a string and string array into: interface Props { someString: string; stringArray: Array<string | Token> | Token; } The latter was not intended. We now emit: interface Props { someString: string; stringArray: string[]; } Since the Token will be typed as `Object` in Java, this change now makes it impossible to mistakenly pass any old java Object. A typical case would be pass a `Subnet` where a `string subnetId` was expected, failing in a nonobvious way. Fixes #2030.
rix0rrr
added a commit
to alex-berger/aws-cdk
that referenced
this issue
Mar 19, 2019
Because of accepted Tokenized values, cfn2ts previously translated a string and string array into: interface Props { someString: string; stringArray: Array<string | Token> | Token; } The latter was not intended. We now emit: interface Props { someString: string; stringArray: string[]; } Since the Token will be typed as `Object` in Java, this change now makes it impossible to mistakenly pass any old java Object. A typical case would be pass a `Subnet` where a `string subnetId` was expected, failing in a nonobvious way. Fixes aws#2030.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I have an error when I create a TransitGateway attachment with a very simple code
I create a VPC with one subnet, create a transit gateway and attach the VPC. Simple.
The Java Exception is:
Is there anything I can do? is there anything I am doing wrong? BTW I am not sure if this is relevant, but maven compile works just fine. Its the synth where things go wrong.
The text was updated successfully, but these errors were encountered: