fix(toolkit): 'cdk deploy' support updates to Outputs #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If only stack Outputs are changed, CloudFormation generates a ChangeSet that is executable but has 0 changes. Before, we looked at the amount of changes to say there was nothing to do, but now we look at the actual change set status to determine whether it's an empty change set or not. The effect is that we can now deploy updates even if only Outputs changed. This becomes very important when the only thing changed to a stack is an Output got added because a cross-stack reference was taken by a downstream stack. Fixes #778.
rix0rrr
changed the title
eladb
approved these changes
Mar 17, 2019
| * Its the responsibility of the consumer to replace all calls that | ||
| * actually will be called. | ||
| */ | ||
| export class FakeSDK extends SDK { |
RomainMuller
approved these changes
Mar 18, 2019
| // tslint:disable-next-line:max-line-length | ||
| throw new Error(`Failed to create ChangeSet ${changeSetName} on ${stackName}: ${description.Status || 'NO_STATUS'}, ${description.StatusReason || 'no reason provided'}`); | ||
| }); | ||
|
|
||
| if (!ret) { | ||
| throw new Error('Change set took too long to be created; aborting'); |
There was a problem hiding this comment.
Is this really a failure mode here? Like... some kind of a timeout?
There was a problem hiding this comment.
What is the question? Can this really happen in practice, can the code path be taken, ...?
| * there are changes to Outputs, the change set can still be executed. | ||
| */ | ||
| export function changeSetHasNoChanges(description: CloudFormation.DescribeChangeSetOutput) { | ||
| return description.Status === 'FAILED' |
There was a problem hiding this comment.
Is this 4-space indented?
rix0rrr
added a commit
to alex-berger/aws-cdk
that referenced
this pull request
Mar 19, 2019
If only stack Outputs are changed, CloudFormation generates a ChangeSet that is executable but has 0 changes. Before, we looked at the amount of changes to say there was nothing to do, but now we look at the actual change set status to determine whether it's an empty change set or not. The effect is that we can now deploy updates even if only Outputs changed. This becomes very important when the only thing changed to a stack is an Output got added because a cross-stack reference was taken by a downstream stack. Fixes aws#778.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If only stack Outputs are changed, CloudFormation generates a ChangeSet
that is executable but has 0 changes.
Before, we looked at the amount of changes to say there was nothing to
do, but now we look at the actual change set status to determine
whether it's an empty change set or not.
The effect is that we can now deploy updates even if only Outputs
changed. This becomes very important when the only thing changed
to a stack is an Output got added because a cross-stack reference
was taken by a downstream stack.
Fixes #778.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.