-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecs.TaskDefinition taskRole and executionRole is not of type IRole #1925
ecs.TaskDefinition taskRole and executionRole is not of type IRole #1925
Comments
Due to |
In my case |
I've come across effectively the same problem in C#. |
The role input parameters are currently Roles but should be IRoles. Required adding the grant methods to the `IRole` definition, which weren't there before. Fixes #1925.
The role input parameters are currently Roles but should be IRoles. Required adding the grant methods to the `IRole` definition, which weren't there before. Fixes #1925.
Thank you @rix0rrr. |
The role input parameters are currently Roles but should be IRoles. Required adding the grant methods to the `IRole` definition, which weren't there before. Fixes aws#1925.
In the construction of the
TaskDefinition
, thetaskRole
property is of typeRole
rather thanIRole
. Same goes forexecutionRole
.https://github.com/awslabs/aws-cdk/blob/488935ce9e2a414c94fbf13fc24c95c9626f7d11/packages/%40aws-cdk/aws-ecs/lib/base/task-definition.ts#L26
https://github.com/awslabs/aws-cdk/blob/488935ce9e2a414c94fbf13fc24c95c9626f7d11/packages/%40aws-cdk/aws-ecs/lib/base/task-definition.ts#L33
Possibly here too ...
https://github.com/awslabs/aws-cdk/blob/488935ce9e2a414c94fbf13fc24c95c9626f7d11/packages/%40aws-cdk/aws-ecs/lib/base/task-definition.ts#L115
The text was updated successfully, but these errors were encountered: