Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to set instance parameter group on instances in rds.DatabaseCluster #1693

Closed
aaronbrashears opened this issue Feb 6, 2019 · 5 comments · Fixed by #2187
Closed

Unable to set instance parameter group on instances in rds.DatabaseCluster #1693

aaronbrashears opened this issue Feb 6, 2019 · 5 comments · Fixed by #2187
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database feature-request A feature should be added or improved.

Comments

@aaronbrashears
Copy link

aaronbrashears commented Feb 6, 2019 •
edited
Loading

When building an rds.DatabaseCluster, there is no obvious way to associate an instance parameter group to instances in the cluster. Without this, there's no way to set common configuration like log_min_duration_statement or shared_preload_libraries.
@eladb
Copy link
Contributor

eladb commented Feb 11, 2019

As a workaround, can you use escape hatches?

@eladb eladb added feature-request A feature should be added or improved. @aws-cdk/aws-rds Related to Amazon Relational Database labels Feb 11, 2019
@aaronbrashears
Copy link
Author

I believe instantiating a rds.CfnDBParameterGroup and then set the dbParameterGroupName for every AWS::RDS::DBInstance in the construct's children would work.

@aereal
Copy link

aereal commented Mar 20, 2019

I also want this improvement.
There is any blocker on this issue?

If there is no problem, I'll send a pull request.

How about this? @eladb

@eladb
Copy link
Contributor

eladb commented Mar 20, 2019

@aereal +1

@aereal aereal mentioned this issue Mar 22, 2019
Closed
4 tasks
@aereal
Copy link

aereal commented Mar 22, 2019

sent #2075

@jogold jogold mentioned this issue May 30, 2019
Merged
4 tasks
rix0rrr pushed a commit that referenced this issue May 31, 2019
@jogold @rix0rrr
feat(rds): add support for database instances (#2187)
b864041 
Specific classes are exposed for a source database instance (`DatabaseInstance`), an instance created from a snapshot (`DatabaseInstanceFromSnapshot`) and a read replica instance (`DatabaseInstanceReadReplica`).

Add construct for option groups and refactor parameter groups.

Add basic support for instance event rules.

Integration with Secrets Manager and secret rotation.

Closes #2075 
Closes #1693
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 13, 2019
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rds): add support for database instances jogold/aws-cdk
3 participants
@aereal @aaronbrashears @eladb