-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(awslint): construct-base-is-private, resource-attribute (#2349)
Refactor the rule implementation of awslint such that the context of each linter is implemented as a `XxxReflection` class (i.e. `ConstructReflection`, `ResourceReflection`). This increases our ability to reuse the model extracted from the type system in other linters. - `awslint:construct-base-is-private` will recommend that XxxBase are internal (required merging some files in some places) - `awslint:resource-attribute`: implement missing attributes from several modules - In some places, move the `ImportedXxx` class into the import method as a local class (makes the implementation much nicer because it's closed by the function call). Misc: - update "foreach.sh" to ignore undefined npm scripts - update contribution guide with instructions on how to use foreach.sh Fixes #2426 Fixes #2409 BREAKING CHANGE: `s3.Bucket.domainName` renamed to `s3.Bucket.bucketDomainName`. * `codedeploy.IXxxDeploymentConfig.deploymentConfigArn` is now a property and not a method. * `ec2.SecurityGroupBase` is now private * `ec2.VpcNetworkBase` is now private * `kinesis.StreamBase` is now private * `kms.EncryptionKeyBase` is now private * `logs.LogGroupBase` is now private * `ssm.ParameterBase` is now private * `eks.ClusterBase` is now private * `codebuild.ProjectBase` is now private * `codecommit.RepositoryBase` is now private * `codedeploy.ServerDeploymentGroupBase` is now private * `eks.ClusterBase` is now private * `lambda.LayerVersionBase` is now private * `rds.DatabaseClusterBase` is now private * `secretsmanager.SecretBase` is now private * `ses.ReceiptRuleSetBase` is now private
- Loading branch information
Elad Ben-Israel
authored
May 1, 2019
1 parent
09d66a0
commit 973b506
Showing
47 changed files
with
1,374 additions
and
927 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.