Mqtt311 decoder #311
Merged
Mqtt311 decoder #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 81.10% 81.69% +0.59%
==========================================
Files 18 19 +1
Lines 7842 7923 +81
==========================================
+ Hits 6360 6473 +113
+ Misses 1482 1450 -32
☔ View full report in Codecov by Sentry. |
sbSteveK
reviewed
Jul 24, 2023
sbSteveK
reviewed
Jul 24, 2023
graebm
reviewed
Jul 25, 2023
| if (handler != NULL) { | ||
| return handler(packet_cursor, decoder->config.handler_user_data); | ||
| } else { | ||
| return aws_raise_error(AWS_ERROR_MQTT_PROTOCOL_ERROR); |
There was a problem hiding this comment.
trivial: just FYI, if you wanted to logging from within this file but didn't know what ID to use...
I usually pass a void *logging_id in the decoder_options, so the decoder can log with the same ID as the the system that owns it
graebm
reviewed
Jul 25, 2023
sbSteveK
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we could have fixed the original bug without doing such a heavyweight refactor, testing complex, brittle logic embedded in the channel handler's vtable implementation is a lousy approach. Rather than graft more hacks and more complexity into the client impl, we add a new subsystem with a testable API.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.