Introduce new configuration parameter failoverMode #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
changed the title
karenc-bq
approved these changes
May 9, 2023
Contributor
|
The failover parameters table will also need to be updated. |
crystall-bitquill
approved these changes
May 9, 2023
congoamz
reviewed
May 9, 2023
| this.failoverReaderConnectTimeoutMsSetting = | ||
| FAILOVER_READER_CONNECT_TIMEOUT_MS.getInteger(this.properties); | ||
| this.enableFailoverStrictReaderSetting = ENABLE_FAILOVER_STRICT_READER.getBoolean(this.properties); | ||
| this.failoverModeSetting = FailoverMode.fromValue(FAILOVER_MODE.getString(this.properties)); |
Contributor
There was a problem hiding this comment.
Would it work to remove the failoverModeSetting variable and just set set this.failoverMode to the value in the props? It looks like we set failoverMode to failoverModeSetting in initHostProvider anyways so I'm not sure if we need both variables
congoamz
reviewed
May 9, 2023
| | `enableFailoverStrictReader` | Boolean | No | Set to `true` to only allow failover to reader nodes during the reader failover process. If enabled, reader failover to a writer node will only be allowed for single-node clusters. This logic mimics the logic of the Aurora read-only cluster endpoint. | `false` | | ||
| | Parameter | Value | Required | Description | Default Value | | ||
| |----------------------------------------|:-------:|:--------------------------------------------------------------------------------:|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `failoverMode` | String | No | Defines a mode for failover process. Failover process may prioritize nodes with different roles and connect to them. Possible values: <br><br>- `strict-writer` - Failover process follows writer node and connects to a new writer when it changes.<br>- `reader-or-writer` - During failover the driver tries to connect to any available/accessing reader node. If no reader is available, the driver can connect to a writer node. This logic mimics the logic of the Aurora read-only cluster endpoint.<br>- `strict-reader` - The driver tries to connect to any available reader node. If no reader is available, the driver raises an error. Reader failover to a writer node will only be allowed for single-node clusters. This logic mimics the logic of the Aurora read-only cluster endpoint.<br><br>If this parameter is omitted, default value depends on connection url. For Aurora read-only cluster endpoint, it's set to `reader-or-writer`. Otherwise, it's `strict-writer`. | Default value depends on connection url. For Aurora read-only cluster endpoint, it's set to `reader-or-writer`. Otherwise, it's `strict-writer`. | |
Contributor
There was a problem hiding this comment.
nit: I'd just say 'accessible' instead of 'available/accessing'
| | `enableFailoverStrictReader` | Boolean | No | Set to `true` to only allow failover to reader nodes during the reader failover process. If enabled, reader failover to a writer node will only be allowed for single-node clusters. This logic mimics the logic of the Aurora read-only cluster endpoint. | `false` | | ||
| | Parameter | Value | Required | Description | Default Value | | ||
| |----------------------------------------|:-------:|:--------------------------------------------------------------------------------:|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `failoverMode` | String | No | Defines a mode for failover process. Failover process may prioritize nodes with different roles and connect to them. Possible values: <br><br>- `strict-writer` - Failover process follows writer node and connects to a new writer when it changes.<br>- `reader-or-writer` - During failover the driver tries to connect to any available/accessing reader node. If no reader is available, the driver can connect to a writer node. This logic mimics the logic of the Aurora read-only cluster endpoint.<br>- `strict-reader` - The driver tries to connect to any available reader node. If no reader is available, the driver raises an error. Reader failover to a writer node will only be allowed for single-node clusters. This logic mimics the logic of the Aurora read-only cluster endpoint.<br><br>If this parameter is omitted, default value depends on connection url. For Aurora read-only cluster endpoint, it's set to `reader-or-writer`. Otherwise, it's `strict-writer`. | Default value depends on connection url. For Aurora read-only cluster endpoint, it's set to `reader-or-writer`. Otherwise, it's `strict-writer`. | |
Contributor
There was a problem hiding this comment.
"reader-or-writer - During failover the driver tries to connect to any available/accessing reader node."
- Should
accessinginstead beaccessible?
"If no reader is available, the driver can connect to a writer node."
- Should change
cantowill.
"strict-reader - The driver tries to connect to any available reader node...."
- Might be good to begin this something like "During failover, the driver tries....".
fix RW split tests fix writer failover
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce new configuration parameter "failoverMode"
Additional Reviewers
@karenc-bq
@aaron-congo
@davecramer
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.