Fix bug where inTransaction was not set to false when autocommit was switched from false to true #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aaron-congo
commented
Dec 9, 2022
aaron-congo
commented
- According to the Connection#setAutoCommit documentation, transactions are committed when autocommit is switched from false to true. This commit fixes a bug where inTransaction was not set to false when this occurred
added 5 commits
December 7, 2022 14:36
karenc-bq
approved these changes
Dec 9, 2022
added 2 commits
December 9, 2022 12:07
sergiyvamz
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.