Skip to content

Conversation

@aaron-congo
Copy link
Contributor

@aaron-congo aaron-congo commented Nov 22, 2022

  • previously, the interval/timeout values could be set to 0 or Long.MAX_VALUE. This PR changes these values to specified defaults when a user-supplied setting is not available
  • also changed various EFM variables to thread-safe variants. These variables are shared between the main thread and the monitor thread

@aaron-congo aaron-congo changed the title Fix bug where monitor timeout could be set to Long.MAX_VALUE Use default connection check intervals/timeouts in the EFM plugin Dec 20, 2022
@davecramer
Copy link
Contributor

So I'm looking at the title of this and trying to determine how it could be set to MAX_VALUE ?

@congoamz
Copy link
Contributor

congoamz commented Jan 3, 2023

So I'm looking at the title of this and trying to determine how it could be set to MAX_VALUE ?

There were a couple spots where this.connectionCheckInvervalMillis was being set to the return value of findShortestIntervalMillis in the MonitorImpl file. The original implementation of this function returned MAX_VALUE if there were no contexts in the MonitorImpl class. The fix for this specific problem is in the MonitorImpl changes in this PR

@congoamz congoamz merged commit 18bbd8c into aws:main Jan 9, 2023
@karenc-bq karenc-bq deleted the default-monitor-timeout branch January 26, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants