KCL 1.X - Guardrails to avoid checkpoint corruption during resharding #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he DDB sequence number is not SHARD_END. 2. Verify the shard end checkpointing by directly looking up the ddb lease entry
Closed
joshua-kim
reviewed
Jan 26, 2021
| request.setExpected(serializer.getDynamoLeaseCounterExpectation(lease)); | ||
| Map<String, ExpectedAttributeValue> expectations = serializer.getDynamoLeaseCounterExpectation(lease); | ||
| expectations.putAll(serializer.getDynamoLeaseCheckpointExpectation(lease)); | ||
| request.setExpected(expectations); |
There was a problem hiding this comment.
I believe this is also used for leaseRenewal/leaseStealing codepath, where we're heartbeating the lease counter/owner. We don't necessarily expect SHARD_END in this case.
There was a problem hiding this comment.
I don't see this being used anywhere other than checkpoint code path. And we don't expect SHARD_END here. We expect it not to present when we write a non SHARD_END checkpoint.
joshua-kim
reviewed
Jan 26, 2021
| * @param lease | ||
| * @return the attribute value map asserting that the checkpoint state is as expected. | ||
| */ | ||
| default Map<String, ExpectedAttributeValue> getDynamoLeaseCheckpointExpectation(T lease) { |
There was a problem hiding this comment.
Maybe good to rename this to something like getDynamoLeaseShardEndCheckpointExpectation?
There was a problem hiding this comment.
I just want to keep this generic, so that we can add any future state expectations. Also this would set expectation based on checkpoint in the lease.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.