You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Examples should be error-free when run against cargo audit. There has been a PR in aws-sdk-rust that attempts to remove cargo audit's --ignore flags for RUSTSEC-2020-0071 and RUSTSEC-2020-0159. When cargo audit runs as part of CI for the PR, the check should pass, saying that no issues have been found.
Actual behavior
In the said PR, the following examples have been reported in CI to depend upon the chrono crate that can cause potential segfaults (per RUSTSEC-2020-0071). A cargo dependency tree leading to the issue looks as follows:
These examples should update their dependencies so that they do not depend on the chrono crate. An example fix can be found here. Ensure that cargo audit runs in CI so that the check runs against all of the submitted PRs.
This issue is currently blocking the PR to be merged in the main branch.
Steps to reproduce
1. Clone the aws-doc-sdk-examples
2. `cd` into `rust_dev_preview`
3. Run `rm Cargo.lock; cargo audit`, which should generate the report that appeared in CI
Logs / stacktrace (if applicable)
No response
Which SDK were you using?
Rust
Which OS were you using?
macOS
SDK version
No response
OS version
No response
The text was updated successfully, but these errors were encountered:
Expected behavior
Examples should be error-free when run against
cargo audit
. There has been a PR inaws-sdk-rust
that attempts to removecargo audit
's--ignore
flags forRUSTSEC-2020-0071
andRUSTSEC-2020-0159
. Whencargo audit
runs as part of CI for the PR, the check should pass, saying that no issues have been found.Actual behavior
In the said PR, the following examples have been reported in CI to depend upon the
chrono
crate that can cause potential segfaults (per RUSTSEC-2020-0071). A cargo dependency tree leading to the issue looks as follows:These examples should update their dependencies so that they do not depend on the
chrono
crate. An example fix can be found here. Ensure thatcargo audit
runs in CI so that the check runs against all of the submitted PRs.This issue is currently blocking the PR to be merged in the
main
branch.Steps to reproduce
Logs / stacktrace (if applicable)
No response
Which SDK were you using?
Rust
Which OS were you using?
macOS
SDK version
No response
OS version
No response
The text was updated successfully, but these errors were encountered: