-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
Description
We have two files that are just collections of somewhat-unrelated functions. I think there’s some notion of the functions in fw_utils being used only for frameworks, but utils also contains some functions that are used only for frameworks. It's also generally accepted that a generic name such as "util" makes it easy to keeping adding more unrelated functions into a file/module, causing it to become increasingly harder to maintain.
I’d like to move most of these functions to the following locations:
- the new classes proposed in Refactor sagemaker.session.Session #1463
- the new class proposed in Create a single module for generating image URIs #1464
- some new modules where it makes sense (e.g. one for generating names of SageMaker resources)
In addition, I’d like to deprecate the following functions:
get_unsupported_framework_version_error: this function is used only by XGBoost, and goes against the original rationale of not wanting to require a Python SDK upgrade just to use a newer framework version. The alternative would be to have all frameworks follow XGBoost's logic.to_str: this function was written specifically for Python 2 compatibility, so we won’t need it anymore after Drop Python 2 support #1461empty_framework_version_warning: this function is used when customers don’t set framework_version, which will become a required parameter with Require framework_version for framework estimators, models, etc. #1465debug: unused as far as I can tellgenerate_tensorboard_url: unused as far as I can tellextract_name_from_job_arn: this function’s usage was removed in an earlier PRparse_s3_url: this function already has a replacement ins3.pyunique_name_from_base: this function can go to the test files