Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s2n Client Integration Test with Top N Domains #756

Closed
alexw91 opened this issue Mar 20, 2018 · 2 comments
Closed

Add s2n Client Integration Test with Top N Domains #756

alexw91 opened this issue Mar 20, 2018 · 2 comments

Comments

@alexw91
Copy link
Contributor

alexw91 commented Mar 20, 2018

Problem:
Right now we only test s2n's client implementation against s2n's server, OpenSSL server, and a few external domains here.

We'd like our client side integration tests to be more robust at catching some of the "long tail" of possible TLS compatibility bugs with more uncommon TLS libraries.

Proposed Solution:
Update s2n_client_endpoint_handshake_test.py to read domains to handshake with from a file (Eg top_10k_domains.txt) instead of the list of 8 domains currently used. We should be able to create a script to generate our own shortened list from free Top 1 million lists such as Alexa Top Sites or Cisco Top Million Domains.

By adding so many more domains to this test, we'll probably also need to implement additional checks to catch and ignore false positives. One simple check we could do would be to perform two TLS handshakes, one with OpenSSL client and one with s2n client, and only fail the integration test if OpenSSL is successful, but s2n fails or vice/versa.

@alexw91 alexw91 changed the title s2nc Top N Domain Integration Test Add s2n Client Integration Test with Top N Domains Mar 20, 2018
@alexw91 alexw91 added the priority/high Rank 2 label Mar 20, 2018
@alexw91 alexw91 added this to the s2n "1.0" Release milestone Mar 20, 2018
@colmmacc
Copy link
Contributor

I love this item. We also have an Amazon Web Service for this ... https://aws.amazon.com/alexa-top-sites/

@jmayclin
Copy link
Contributor

jmayclin commented Feb 3, 2025

We are cleaning up stale feature requests. Please reopen this issue if you believe it should be reprioritized.

@jmayclin jmayclin closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants