Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce result checking for s2n_stuffer methods #4391

Closed
jmayclin opened this issue Jan 30, 2024 · 0 comments · Fixed by #4399
Closed

enforce result checking for s2n_stuffer methods #4391

jmayclin opened this issue Jan 30, 2024 · 0 comments · Fixed by #4399

Comments

@jmayclin
Copy link
Contributor

Problem:

We currently rely on contributors to remember to check all of the return values from s2n_stuffer method. Relying on people to remember this is no ideal because people can forget, and it creates extra friction in PR comments.

Solution:

Similar to #4389, we can enforce that the return values from s2n_stuffer methods are used. This way customers will receive an error message if they forget to check the return value.

Requirements / Acceptance Criteria:

Customers must receive an error when s2n_stuffer return values are not checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants