Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make S2N_CERT_AUTH_OPTIONAL the default for clients #4382

Closed
lrstewart opened this issue Jan 26, 2024 · 0 comments · Fixed by #4390
Closed

Make S2N_CERT_AUTH_OPTIONAL the default for clients #4382

lrstewart opened this issue Jan 26, 2024 · 0 comments · Fixed by #4390

Comments

@lrstewart
Copy link
Contributor

Problem:

Currently clients default to S2N_CERT_AUTH_NONE (reject any attempt at mutual auth). That makes sense for servers, but seems strange for clients, which don't necessarily know ahead of time if servers will request client auth or not.

See #4381

Solution:

Investigate reasoning behind old behavior.
Change the default behavior.

  • Does this change what S2N sends over the wire? If yes, explain.
  • Does this change any public APIs? If yes, explain.
  • Which versions of TLS will this impact?

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

  • RFC links: Links to relevant RFC(s)
  • Related Issues: Link any relevant issues
  • Will the Usage Guide or other documentation need to be updated?
  • Testing: How will this change be tested? Call out new integration tests, functional tests, or particularly interesting/important unit tests.
    • Will this change trigger SAW changes? Changes to the state machine, the s2n_handshake_io code that controls state transitions, the DRBG, or the corking/uncorking logic could trigger SAW failures.
    • Should this change be fuzz tested? Will it handle untrusted input? Create a separate issue to track the fuzzing work.

Out of scope:

Is there anything the solution will intentionally NOT address?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants