Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen Work Tracking Issue #3314

Closed
9 tasks done
lundinc2 opened this issue May 11, 2022 · 2 comments
Closed
9 tasks done

Doxygen Work Tracking Issue #3314

lundinc2 opened this issue May 11, 2022 · 2 comments
Labels

Comments

@lundinc2
Copy link
Contributor

lundinc2 commented May 11, 2022

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify
AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

We need to introduce doxygen to s2n-tls to create standardized documentation for the public API.

Resolves

Solution:

  • Add a doxygen config
  • Add doxygen to s2n.h
  • Add a doxygen CI job
  • Resolve doxygen warnings for s2n.h
  • Updated doxygen CI job to fail when a doxygen warning is introduced
  • Add doxygen output to gh-pages branch
  • Consider adding doxygen to release script, and push doxygen artifacts with release
  • Prettify doxygen output by updating layout.xml and CSS
  • Create a task to trim function definitions from USAGE_GUIDE.md
  • Does this change what S2N sends over the wire? If yes, explain.
    No
  • Does this change any public APIs? If yes, explain.
    No
  • Which versions of TLS will this impact?
    No

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

  • RFC links: Links to relevant RFC(s)
  • Related Issues: Link any relevant issues
  • Will the Usage Guide or other documentation need to be updated?
  • Testing: How will this change be tested? Call out new integration tests, functional tests, or particularly interesting/important unit tests.
    • Will this change trigger SAW changes? Changes to the state machine, the s2n_handshake_io code that controls state transitions, the DRBG, or the corking/uncorking logic could trigger SAW failures.
    • Should this change be fuzz tested? Will it handle untrusted input? Create a separate issue to track the fuzzing work.

Out of scope:

Is there anything the solution will intentionally NOT address?

@lundinc2
Copy link
Contributor Author

lundinc2 commented Jun 2, 2022

We've opted to not include the doxygen output in the release artifacts for now. If this turns out to be a priority we will address it then.

@toidiu toidiu added the s2n-core team label Jun 6, 2022
@zaherd
Copy link

zaherd commented Feb 16, 2023

All tasks are done

@zaherd zaherd closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants