Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky s2n_session_ticket_test #1563

Closed
alexw91 opened this issue Feb 20, 2020 · 1 comment
Closed

Fix Flaky s2n_session_ticket_test #1563

alexw91 opened this issue Feb 20, 2020 · 1 comment

Comments

@alexw91
Copy link
Contributor

alexw91 commented Feb 20, 2020

Problem:

This test failed on this Travis Job: https://travis-ci.org/awslabs/s2n/jobs/652641395
But passed when the build was retried.

Running s2n_session_ticket_test.c                          ... NOTE: Some details are omitted, run with S2N_PRINT_STACKTRACE=1 for a verbose backtrace.
See https://github.com/awslabs/s2n/blob/master/docs/USAGE-GUIDE.md
FAILED test 310
(memcmp( (serialized_session_state + 1 + 2), (ticket_key_name2), (strlen((char *)ticket_key_name2)) )) == (0) is not true  (s2n_session_ticket_test.c line 774)
Error Message: 'no error'
 Debug String: 'Error encountered in s2n_recv.c line 69'
 System Error: Socket operation on non-socket (88)
Makefile:63: recipe for target 's2n_session_ticket_test' failed
make[2]: *** [s2n_session_ticket_test] Error 1
make[2]: *** Waiting for unfinished jobs....

Proposed Solution:

Investigate and fix the root cause of the flaky test.

@alexw91 alexw91 changed the title Fix Flaky s2n_session_ticket_test Test Fix Flaky s2n_session_ticket_test Feb 20, 2020
@dougch dougch added the s2n-core team label Mar 23, 2022
@maddeleine
Copy link
Contributor

I recently merged a fix for this test, should have caused this specific instance of flakiness to go away: #3913.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants