fix: move CW streaming client to tarball #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imykhai
approved these changes
Jan 23, 2025
|
As far as I understand, with this PR you should also include codewhisperer-streaming as a bundled dependency into the lsp-codewhisperer package.json https://docs.npmjs.com/cli/v11/configuring-npm/package-json#bundledependencies |
ege0zcan
approved these changes
Jan 23, 2025
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently have dependency issues with codewhisperer-streaming client. Compiling step fails when package-lock.json is deleted.
Solution
Packed streaming client compiled code into a tarball (
npm pack) and deleted source code from the repo.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.