Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q/codewhisperer does not declare its position encoding #732

Open
justinmk3 opened this issue Jan 20, 2025 · 0 comments
Open

Q/codewhisperer does not declare its position encoding #732

justinmk3 opened this issue Jan 20, 2025 · 0 comments

Comments

@justinmk3
Copy link
Contributor

justinmk3 commented Jan 20, 2025

Problem

It seems like codewhisperer server expects utf-8 encoding,

const data = await fs.readFile(file, { encoding: 'utf8' });

but the default LSP encoding is utf-16.

Expected behavior

  • Document the expected position encoding in the readme
  • Declare the expected position encoding from the server settings/capabilities, so that clients don't have to guess it.
  • (Optional) Declare utf-8 as the encoding expected by all the lsp servers in this repo? Mention this in the top-level docs, wherever those are...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant