-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IAM Credential Authentication in AWS Q Developer/CodeWhisperer #262
Comments
Hi Todd, |
I see that #264 was merged @viktorsaws: https://github.com/aws/language-servers/blob/main/app/aws-lsp-codewhisperer-binary/src/iam-standalone.ts This definitely unblocks me now, but we should iterate towards an LSP server that accepts either Builder ID bearer tokens or IAM credentials without needing to switch the executable. Switching the executable is very inconvenient to any LSP plugins in Sublime Text. Should we use this GitHub issue for tracking this? |
Sorry for the delay. Is this something that would still be useful? |
I am closing this issue since there is no update for over a month, if this is still required we will track a separate discussion |
This would still be useful. The LSP ecosystem for Sublime Text defines the path to the executable for the LSP server statically, and it will be painful to bifurcate this based on configuration. |
Is your feature request related to a problem? Please describe.
The LSP server for AWS Q Developer is only supporting Bearer tokens at this time and not IAM credentials:
You can see this here effectively:
language-servers/app/aws-lsp-codewhisperer-binary/src/index.ts
Line 16 in c5a9b58
language-servers/server/aws-lsp-codewhisperer/src/language-server/proxy-server.ts
Line 8 in c5a9b58
language-servers/server/aws-lsp-codewhisperer/src/language-server/codeWhispererService.ts
Line 97 in c5a9b58
Describe the solution you'd like
Code search shows that nothing is actually referencing
CodeWhispererServiceIAM
effectively yet:language-servers/server/aws-lsp-codewhisperer/src/language-server/codeWhispererServer.ts
Line 566 in 638b123
I will either need to get bearer tokens for a Builder ID, or we'll need to bridge the gap for supporting IAM-based authentication for the LSP service. As an internal employee at Amazon, it is significantly easier for me to use IAM credentials over a bearer token for a Builder ID.
The text was updated successfully, but these errors were encountered: