From f49ee1b747c8fe60e7f5e2bb27a6db4cd28f77ac Mon Sep 17 00:00:00 2001 From: GavinRay97 Date: Sat, 12 Sep 2020 19:48:55 -0400 Subject: [PATCH 1/3] feat(manifest): Add notes about gotchas - template I'm not entirely sure about all of these, but I think these are generally the case. If mistaken about these can remove, but think it would be really helpful and prevent headaches to list common gotchas here when generating the template. --- templates/workloads/services/lb-web/manifest.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/templates/workloads/services/lb-web/manifest.yml b/templates/workloads/services/lb-web/manifest.yml index 2158a9e006c..dcc3ba3de5f 100644 --- a/templates/workloads/services/lb-web/manifest.yml +++ b/templates/workloads/services/lb-web/manifest.yml @@ -16,10 +16,17 @@ image: http: # Requests to this path will be forwarded to your service. # To match all requests you can use the "/" path. + # NOTE: If you plan to deploy multiple services, this value must be unique per-service + # NOTE: It is unnecessary to start the path with a "/", for example "/api" versus "api" path: '{{.Path}}' # You can specify a custom health check path. The default is "/" + # WARNING: Passing healthchecks are required and are how ECS measures task health. Failure to pass healthcheck may result cyclical restarts. + # NOTE: The healthcheck URL should be appended to the "path" value. + # For example, if "path" is set to "api", and your API serves it's healthcheck on "/healthz", this value should be "/api/healthz" # healthcheck: '{{.HealthCheckPath}}' +# NOTE: Not all values for CPU + Memory are valid, refer to below link for valid value pairs: +# https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-cpu-memory-error.html # Number of CPU units for the task. cpu: {{.CPU}} # Amount of memory in MiB used by the task. From c3f863a3bbec514774f99d37f3d3a33ca7b55939 Mon Sep 17 00:00:00 2001 From: GavinRay97 Date: Sun, 13 Sep 2020 15:10:32 -0400 Subject: [PATCH 2/3] Update templates/workloads/services/lb-web/manifest.yml Co-authored-by: Efe Karakus --- templates/workloads/services/lb-web/manifest.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/templates/workloads/services/lb-web/manifest.yml b/templates/workloads/services/lb-web/manifest.yml index dcc3ba3de5f..d7f3d5485d8 100644 --- a/templates/workloads/services/lb-web/manifest.yml +++ b/templates/workloads/services/lb-web/manifest.yml @@ -16,9 +16,7 @@ image: http: # Requests to this path will be forwarded to your service. # To match all requests you can use the "/" path. - # NOTE: If you plan to deploy multiple services, this value must be unique per-service - # NOTE: It is unnecessary to start the path with a "/", for example "/api" versus "api" - path: '{{.Path}}' + path: '{{.Path}}' {{if ne .Path "/"}} # Must be unique per-service when deploying multiple services. {{end}} # You can specify a custom health check path. The default is "/" # WARNING: Passing healthchecks are required and are how ECS measures task health. Failure to pass healthcheck may result cyclical restarts. # NOTE: The healthcheck URL should be appended to the "path" value. From 70a5b93f36daa54d4db400bdf0ddc09f0ff3076c Mon Sep 17 00:00:00 2001 From: GavinRay97 Date: Sun, 13 Sep 2020 15:13:19 -0400 Subject: [PATCH 3/3] Remove note about valid CPU/Mem pairs per suggestion --- templates/workloads/services/lb-web/manifest.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/templates/workloads/services/lb-web/manifest.yml b/templates/workloads/services/lb-web/manifest.yml index d7f3d5485d8..da38f4ec85e 100644 --- a/templates/workloads/services/lb-web/manifest.yml +++ b/templates/workloads/services/lb-web/manifest.yml @@ -23,8 +23,6 @@ http: # For example, if "path" is set to "api", and your API serves it's healthcheck on "/healthz", this value should be "/api/healthz" # healthcheck: '{{.HealthCheckPath}}' -# NOTE: Not all values for CPU + Memory are valid, refer to below link for valid value pairs: -# https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-cpu-memory-error.html # Number of CPU units for the task. cpu: {{.CPU}} # Amount of memory in MiB used by the task.