Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBC URL config example is unclear #229

Open
eoliphan opened this issue Jun 3, 2024 · 1 comment
Open

JDBC URL config example is unclear #229

eoliphan opened this issue Jun 3, 2024 · 1 comment

Comments

@eoliphan
Copy link

eoliphan commented Jun 3, 2024

Describe the bug
The Usage Example indicates that setting the db url to this driver's scheme (jdbc-secretsmanager) will result in it being 'intercepted' by the driver.

This (to me at least) indicates that the driver will replace the 'jdbc-secretsmanager:...' url with the one in the AWS Secret. When in fact this config only results in the 'jdbc-secretsmanager"' bing replaced with 'jdbc:' (presumably to allow you to only manage the un/pw in AWS Secrets Manager?)

Expected behavior
Usage example should document that the rest of the url is passed as is if 'jdbc-secretsmanager:' scheme is used, and that if you wish to pull all the connection info from the secret, that the secret id should be used as the url as well.

Also, the examples in the AWS Docs do make this clear

@eoliphan eoliphan added the bug Something isn't working label Jun 3, 2024
@jbct
Copy link

jbct commented Jun 10, 2024

Hi @eoliphan, thank you for the feedback. We will look into making this more clear.

@jbct jbct removed the bug Something isn't working label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants