Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws::KMS::Client#encrypt logs plaintext: param #908

Closed
modosc opened this issue Aug 21, 2015 · 3 comments
Closed

Aws::KMS::Client#encrypt logs plaintext: param #908

modosc opened this issue Aug 21, 2015 · 3 comments
Labels
feature-request A feature should be added or improved.

Comments

@modosc
Copy link

modosc commented Aug 21, 2015

versions:

aws-sdk (2.1.14)
aws-sdk-rails (1.0.0)

with Aws.config.update log_level: :debug any calls to Aws::KMS::Client#encrypt are logged including the plaintext:

[Aws::KMS::Client 200 0.131191 0 retries] encrypt(key_id:"arn:aws:kms:us-west-2:12324123412324:key/1420d94d-15ea-43bd-9fe0-2792289f189b",plaintext:"asdfasdfasdf")

seems like this param should be filtered, maybe something similar to the rails config.filter_parameters implementation?

@trevorrowe trevorrowe added Version 2 feature-request A feature should be added or improved. labels Aug 24, 2015
@trevorrowe
Copy link
Member

Thank you for reporting this issue. I definitely agree these should be filtered from the default logger output. I'm going to take a look at this today and see what we can do to resolve this.

@trevorrowe
Copy link
Member

I made a change to the SDK so that it will now filter sensitive parameters by default when logging request parameters. The default list will be auto-updated by checking the service definitions as an automated release task. You can add additional filters when constructing a log formatter.

@modosc
Copy link
Author

modosc commented Aug 25, 2015

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants