Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: should state that all connections are made through SSL #901

Closed
tonatiuh opened this issue Aug 18, 2015 · 1 comment
Closed
Labels
documentation This is a problem with documentation.

Comments

@tonatiuh
Copy link

In the AWS documentation is stated that "you should transmit your requests using Secure Sockets Layer (SSL) by using HTTPS." (http://docs.aws.amazon.com/general/latest/gr/signing_aws_api_requests.html#why-requests-are-signed), which makes sense and in my case is a requirement; in order to find if this client is connecting through SSL I needed to check a lot in the code and internet until I found: https://github.com/aws/aws-sdk-ruby/blob/v2.1.7/aws-sdk-core/lib/seahorse/client/net_http/connection_pool.rb#L262 and https://gitter.im/aws/aws-sdk-ruby?at=550202d0338c496703ffb9cb.

So, I think the fact SSL is enabled by default should be stated in the documentation since IMO that's an important feature.

@tonatiuh tonatiuh changed the title Documentation: establish that all connections are made through SSL Documentation: should state that all connections are made through SSL Aug 18, 2015
@trevorrowe trevorrowe added Version 2 documentation This is a problem with documentation. labels Aug 19, 2015
@trevorrowe
Copy link
Member

I added a note to the README to address this. Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation.
Projects
None yet
Development

No branches or pull requests

2 participants