feat(types): update identity types #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
sra-identity-types
branch
4 times, most recently
from
6b3d54f to
5a8af94
Compare
syall
commented
Nov 15, 2022
AndrewFossAWS
approved these changes
Nov 16, 2022
syall
commented
Nov 16, 2022
trivikr
requested changes
Nov 17, 2022
syall
force-pushed
the
sra-identity-types
branch
from
3975079 to
a2aae01
Compare
added 2 commits
November 17, 2022 18:27
As part of refactoring identity resolution, update the existing types and add new types with backwards compatibility.
Use the VS Code "Rename Symbol" tool for: - `Credentials` to `AwsCredentialIdentity` - `CredentialProvider` to `AwsCredentialIdentityProvider` Manually rename using `\bCredentialProvider\b` and `\bCredentials\b`: - `Credentials` to `AwsCredentialIdentity` - `CredentialProvider` to `AwsCredentialIdentityProvider` Manually rename using `\bTokenProvider\b` and `\bToken\b`: - `Token` to `TokenIdentity` - `TokenProvider` to `TokenIdentityProvider`
syall
force-pushed
the
sra-identity-types
branch
from
a2aae01 to
b4c10db
Compare
trivikr
approved these changes
Nov 18, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
N/A
Description
What does this implement/fix? Explain your changes.
As part of refactoring identity resolution, update the existing
types and add new types with backwards compatibility.
Use the VS Code "Rename Symbol" tool for:
CredentialstoAwsCredentialIdentityCredentialProvidertoAwsCredentialIdentityProviderManually rename using
\bCredentialProvider\band\bCredentials\b:CredentialstoAwsCredentialIdentityCredentialProvidertoAwsCredentialIdentityProviderManually rename using
\bTokenProvider\band\bToken\b:TokentoTokenIdentityTokenProvidertoTokenIdentityProviderTesting
How was this change tested?
yarn build:allyarn test:allAdditional context
Add any other context about the PR here.
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.