Missed tslib dependency in @aws-sdk/types 3.199.0

[koshic]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

Base tsconfig for cjs has importHelpers: true, so 'tslib' must be in dependencies for any compiled package:

aws-sdk-js-v3/tsconfig.cjs.json

Lines 3 to 5 in f9bc7af

	"compilerOptions": {
	"importHelpers": true,
	"module": "commonjs",

'types' package has no dependencies, only devDependencies:

aws-sdk-js-v3/packages/types/package.json

Lines 42 to 49 in f9bc7af

	"devDependencies": {
	"@tsconfig/recommended": "1.0.1",
	"concurrently": "7.0.0",
	"downlevel-dts": "0.10.1",
	"rimraf": "3.0.2",
	"typedoc": "0.19.2",
	"typescript": "~4.6.2"
	}

It could be ok for types-only (in TS terms) package, but 'middleware-sdk-s3' imports EndpointURLScheme enum from 'types' package:

aws-sdk-js-v3/packages/util-endpoints/src/lib/parseURL.ts

Lines 1 to 8 in f9bc7af

	import { Endpoint, EndpointURL, EndpointURLScheme } from "@aws-sdk/types";
	import { isIpAddress } from "./isIpAddress";
	const DEFAULT_PORTS: Record<EndpointURLScheme, number> = {
	[EndpointURLScheme.HTTP]: 80,
	[EndpointURLScheme.HTTPS]: 443,
	};

And yes, dist-cjs/index.js requires 'tslib':

As a result, we have an error inside strict environment like Yarn PnP:

@aws-sdk/types tried to access tslib, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
Required package: tslib
Required by: @aws-sdk/types@npm:3.193.0 (via <doesnt matter>/.yarn/cache/@aws-sdk-types-npm-3.193.0-3d57d20985-2979d25628.zip/node_modules/@aws-sdk/types/)

In my case stack trace begins from 's3-client'.

SDK version number

3.194.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v19.0.0

Reproduction Steps

yarn pnp, cjs, s3-client and SelectObjectContentCommand.

Observed Behavior

'missed dependency'

Expected Behavior

no error

Possible Solution

add missed dependency to 'types' package

Additional Information/Context

No response

[dszczepaniak-cksource]

I can confirm the issue occurs for @[email protected] as well

[koshic]

Still actual in 3.197.0

[lensbart]

Encountered the issue in 3.199.0

[mhassan1]

This should be resolved by #4128.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.