feat(credential-provider-ini): call fromTokenFile in assumeRole chaining #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## credential-provider-token-file-base #2178 +/- ##
======================================================================
Coverage ? 78.96%
======================================================================
Files ? 383
Lines ? 16231
Branches ? 3526
======================================================================
Hits ? 12816
Misses ? 3415
Partials ? 0 Continue to review full report at Codecov.
|
trivikr
changed the base branch from
credential-provider-token-file-base
to
main
trivikr
force-pushed
the
call-fromTokenFile-from-ini
branch
from
329359f to
612acec
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AllanZhengYP
approved these changes
Mar 25, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #1808
The base branch for this PR would be changed to main after #2177 is merged.Done ✅Description
Call fromTokenFile in assumeRole chaining
Testing
Unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.