From dbb4c04c408cbc0aa7d5e6d239b6f549ebcbd8ca Mon Sep 17 00:00:00 2001 From: Jaykumar Gosar Date: Mon, 6 Mar 2023 12:39:55 -0800 Subject: [PATCH 1/2] Simplify hashCode and equals for ResolveIdentityRequest --- .../amazon/awssdk/identity/spi/ResolveIdentityRequest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/core/identity-spi/src/main/java/software/amazon/awssdk/identity/spi/ResolveIdentityRequest.java b/core/identity-spi/src/main/java/software/amazon/awssdk/identity/spi/ResolveIdentityRequest.java index ac8ad4d0faaf..2a8ab450762e 100644 --- a/core/identity-spi/src/main/java/software/amazon/awssdk/identity/spi/ResolveIdentityRequest.java +++ b/core/identity-spi/src/main/java/software/amazon/awssdk/identity/spi/ResolveIdentityRequest.java @@ -66,14 +66,13 @@ public boolean equals(Object o) { if (o == null || getClass() != o.getClass()) { return false; } - ResolveIdentityRequest that = (ResolveIdentityRequest) o; - return Objects.equals(properties, that.properties); + return properties.equals(that.properties); } @Override public int hashCode() { - return 31 + Objects.hashCode(properties); + return Objects.hashCode(properties); } public static final class Builder implements SdkBuilder { From c2d4465edcf0b8fbec8e250e0fe9333aaefe1e60 Mon Sep 17 00:00:00 2001 From: Jaykumar Gosar Date: Mon, 6 Mar 2023 12:48:00 -0800 Subject: [PATCH 2/2] Fix doc link about AWS access keys To match with updates to `AwsCredentials` in PR 3773. --- .../awssdk/auth/credentials/AwsBasicCredentials.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/auth/src/main/java/software/amazon/awssdk/auth/credentials/AwsBasicCredentials.java b/core/auth/src/main/java/software/amazon/awssdk/auth/credentials/AwsBasicCredentials.java index cf19e36fcab6..1c8b32cd928e 100644 --- a/core/auth/src/main/java/software/amazon/awssdk/auth/credentials/AwsBasicCredentials.java +++ b/core/auth/src/main/java/software/amazon/awssdk/auth/credentials/AwsBasicCredentials.java @@ -25,12 +25,12 @@ import software.amazon.awssdk.utils.Validate; /** - * Provides access to the AWS credentials used for accessing AWS services: AWS access key ID and secret access key. These - * credentials are used to securely sign requests to AWS services. + * Provides access to the AWS credentials used for accessing services: AWS access key ID and secret access key. These + * credentials are used to securely sign requests to services (e.g., AWS services) that use them for authentication. * *

For more details on AWS access keys, see: - * - * http://docs.amazonwebservices.com/AWSSecurityCredentials/1.0/AboutAWSCredentials.html#AccessKeys

+ * + * https://docs.aws.amazon.com/general/latest/gr/aws-sec-cred-types.html#access-keys-and-secret-access-keys

* * @see AwsCredentialsProvider */