From 326960076eb06c514bbc5e77285703771127013a Mon Sep 17 00:00:00 2001 From: David Mollitor Date: Sat, 7 Jan 2023 23:12:54 -0500 Subject: [PATCH 1/2] Do not attempt to pad time string if current length is sufficient --- .../internal/converter/ConverterUtils.java | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/converter/ConverterUtils.java b/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/converter/ConverterUtils.java index 13e68b25cc01..c2db7e7bfcef 100644 --- a/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/converter/ConverterUtils.java +++ b/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/converter/ConverterUtils.java @@ -53,14 +53,19 @@ public static void validateFloat(Float input) { } public static String padLeft(int paddingAmount, int valueToPad) { - String value = Integer.toString(valueToPad); - int padding = paddingAmount - value.length(); - StringBuilder result = new StringBuilder(paddingAmount); - for (int i = 0; i < padding; i++) { - result.append('0'); + final String result; + final String value = Integer.toString(valueToPad); + if (value.length() == paddingAmount) { + result = value; + } else { + int padding = paddingAmount - value.length(); + StringBuilder sb = new StringBuilder(paddingAmount); + for (int i = 0; i < padding; i++) { + sb.append('0'); + } + result = sb.append(value).toString(); } - result.append(value); - return result.toString(); + return result; } public static String[] splitNumberOnDecimal(String valueToSplit) { From 26e8012e7f1387c38a8c842ba0d629788fbe20fb Mon Sep 17 00:00:00 2001 From: belugabehr <12578579+belugabehr@users.noreply.github.com> Date: Mon, 13 Mar 2023 22:55:36 -0400 Subject: [PATCH 2/2] Remove 'final' modifier from local variables --- .../enhanced/dynamodb/internal/converter/ConverterUtils.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/converter/ConverterUtils.java b/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/converter/ConverterUtils.java index c2db7e7bfcef..0f6f20583187 100644 --- a/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/converter/ConverterUtils.java +++ b/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/converter/ConverterUtils.java @@ -53,8 +53,8 @@ public static void validateFloat(Float input) { } public static String padLeft(int paddingAmount, int valueToPad) { - final String result; - final String value = Integer.toString(valueToPad); + String result; + String value = Integer.toString(valueToPad); if (value.length() == paddingAmount) { result = value; } else {