Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flag to disable IMDSv1 fallback #2048

Merged
merged 8 commits into from
Mar 13, 2023
Merged

feat: add flag to disable IMDSv1 fallback #2048

merged 8 commits into from
Mar 13, 2023

Conversation

aajtodd
Copy link
Contributor

@aajtodd aajtodd commented Mar 8, 2023 •
edited
Loading

  • Adds a flag to config to disable IMDSv1 fallback. When enabled the imds.Client will return an error when fetching a token from IMDS fails instead of falling back to the insecure data flow of IMDSv1
    • I did confirm (and tests cover this) that fetching a token is retried

@aajtodd aajtodd requested a review from a team as a code owner March 8, 2023 19:11
@aajtodd aajtodd mentioned this pull request Mar 8, 2023
Merged
@aajtodd aajtodd merged commit c2533c6 into main Mar 13, 2023
@aajtodd aajtodd deleted the aajtodd/imdsv1-disable branch March 13, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucix-aws lucix-aws lucix-aws approved these changes

@isaiahvita isaiahvita isaiahvita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aajtodd @isaiahvita @lucix-aws