Enhance the .NET example #401
Conversation
jfuss
left a comment
jfuss
left a comment
There was a problem hiding this comment.
Couple small things to address.
README.rst
Outdated
|
|
||
| You should then build your ZIP file using your normal build process. | ||
|
|
||
| You can find a .NET Core example in the `sam init` folder. |
There was a problem hiding this comment.
Can we change the wording here to be 'You can generate a .NET Core example by sam init --runtime dotnetcore'? While it is an example, its specific to cookiecutter and could be hard to parse. Generating the sample seems like a better experience to see and play with.
| @@ -0,0 +1,43 @@ | |||
|
|
|||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
There was a problem hiding this comment.
Should this have been committed? Looks like a ide generated file.
There was a problem hiding this comment.
@jfuss in dotnet world the Solution file "glues" the projects. It is an artifact used to make it easy to restore NuGet packages or build the projects in one go. It is an abstraction created by Microsoft.
Started with Visual Studio, but if you use JetBrains Rider, it recognises and uses it.
When you are using Visual Studio Code you do not need it, since VS Code opens a folder.
There was a problem hiding this comment.
O cool. Ya am not a .NET dev :)
There was a problem hiding this comment.
No problem. Sharing is caring! ;)
|
@joaoasrosa This is really awesome! Thanks for doing it and then redoing it :). I am going to hold off and merge for right now. I want to pull down the commit(s) and run locally, as a sanity test (we don't have deep tests for any of this yet). Unfortunately, I am not in a spot to pull this down right now. I may have some time tomorrow when I get back from PyCon. If not, I will handle Wednesday for sure. |
|
@jfuss please let me know if I miss anything. Cheers |
README.rst
Outdated
| Transform: AWS::Serverless-2016-10-31 | ||
|
|
||
| Resources: | ||
| ExampleJavaFunction: |
There was a problem hiding this comment.
When possible, mind changing to ExampleDotNetFunction?
|
That is awesome @joaoasrosa, thank you so much for contributing to that! I knew there was a better way (Cake) but wasn't sure what .Net folks do these days -- Much appreciated! |
|
@heitorlessa thanks for pointing out. :) |
|
@jfuss did you confirm the solution in the PR? |
|
@joaoasrosa I did. Thanks for the reminder ping. |
…aces command (aws#401) * remove output-dir flag and add unformatted flag * fix Optional[bool] params
3 participants
This PR enhance the .NET example in the
sam initexamples:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.