Skip to content

Add a .NET Core 2.0 Hello World sample #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Add a .NET Core 2.0 Hello World sample #377

wants to merge 6 commits into from

Conversation

@joaoasrosa
Copy link
Contributor

@joaoasrosa joaoasrosa commented May 2, 2018

This PR adds a simple HelloWorld sample.
It uses Cake as build platform for the AWS Lambda.

It also updates the documentation to reflect the changes.

MattHodge
MattHodge suggested changes May 8, 2018
View reviewed changes
Copy link

@MattHodge MattHodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the Reflexive edges in graph are not allowed. issue, this runs perfectly on MacOS. 👍

samples/hello-world/dotnetcore2.0/build.cake Outdated

Task("Default")
.Description("This is the default task which will run if no specific target is passed in.")
.IsDependentOn("Default");
Copy link

@MattHodge MattHodge May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes a Reflexive edges in graph are not allowed exception (the task being dependant on itself).

@joaoasrosa
Copy link
Contributor Author

joaoasrosa commented May 9, 2018

@MattHodge thanks for pointing it out. New commit fixing the issue.

MattHodge
MattHodge approved these changes May 9, 2018
View reviewed changes
Copy link

@MattHodge MattHodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly on MacOS too 👍

@ashemedai
Copy link

ashemedai commented May 9, 2018

The refresh messed up this PR now though. :\

@sanathkr
Copy link
Contributor

sanathkr commented May 9, 2018

Yes, it messes up the PR but for a good reason :) We added a dotnet sample consumable by sam init command - https://github.com/awslabs/aws-sam-cli/tree/develop/samcli/local/init/templates. Can you rebase and merge your changes with this sample and update the PR?

sam init is a new command we added in 0.3.0. It allows customers to quickly get started with a sample app in a runtime of their choice without the need to clone repos from Github. Your PR will be way more valuable, and reach more people, if you merge it with the dotnet template vended by sam init

@joaoasrosa
Copy link
Contributor Author

joaoasrosa commented May 9, 2018

@sanathkr will do. Thanks

@ashemedai
Copy link

ashemedai commented May 9, 2018

@sanathkr Ah, I see, all the samples are now cookiecutter templates for init, correct?

@sanathkr
Copy link
Contributor

sanathkr commented May 9, 2018

Precisely!

@sanathkr sanathkr added the stage/in-progress A fix is being worked on label May 10, 2018
@joaoasrosa
Copy link
Contributor Author

joaoasrosa commented May 10, 2018

Closing this PR, in order to preserve the history.
A new PR was open: #401
Thanks for all the feedback @MattHodge, @ashemedai and @sanathkr. @sanathkr let me know if something is missing.

@joaoasrosa joaoasrosa closed this May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MattHodge MattHodge MattHodge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stage/in-progress A fix is being worked on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joaoasrosa @ashemedai @sanathkr @MattHodge