-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Resolve symlinks in sam build #7887
Comments
Thank you for creating this issue. I'll keep this request open for now to collect feedback from the community. With enough support, we will prioritize this feature request accordingly. |
+1 We use Github actions (aws-actions/setup-sam, etc) to build and deploy. Our source code contains symlinks to shared source files. Our current workaround is hard-coding SAM CLI v1.132.0 in .github/workflows/pipeline.yaml:
Would prefer to use a supported parameter instead. |
There's a new parameter added in SAM CLI 1.134.0 called It was just added to the documentation a couple of days ago: https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-cli-command-reference-sam-build.html#ref-sam-cli-build-options-mount-symlinks |
Please bryandatanerds and paulflew, please let us know if |
Yes, that's fixed our GitHub build issue. Thx for the quick response. |
Closing this as the issue is fixed. |
|
Works here too. Thank you very much for adding this back in! |
Describe your idea/feature/enhancement
As requested in #7865, I am opening this as we have a build pipeline that relies on symlinks outside of the build directory being mounted during
sam build
. Our process is to create a temporarybuild/
directory within our repo, symlink only the parts of the repo that should be included in the SAM application into there, and then runsam build --use-container
withCodeUri
pointed to the build directory. Symlinking saves us having to copy most of our source tree.Proposal
We would appreciate if there were a way to tell
sam build --use-container
to mount symlinks outside the build tree.Thank you!
The text was updated successfully, but these errors were encountered: