Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop][Integ-tests] Fix CloudWatch integration tests #6008

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

hanwen-pcluste
Copy link
Contributor

The tests add debug mode and restart cw agent. With a new version, the cw agent does not give complete output right after the agent restart. Therefore, this commit adds 10 seconds sleep after the agent restart

Tests

The following tests have been passed

test-suites:
  cloudwatch_logging:
    test_cloudwatch_logging.py::test_cloudwatch_logging:
      dimensions:
      - instances:
        - m6g.xlarge
        oss:
        - ubuntu2204
        regions:
        - us-east-1
        schedulers:
        - slurm
      - instances:
        - c5.xlarge
        oss:
        - centos7
        regions:
        - us-east-1
        schedulers:
        - slurm
  dcv:
    test_dcv.py::test_dcv_configuration:
      dimensions:
      - instances:
        - g4dn.2xlarge
        oss:
        - alinux2
        regions:
        - us-east-1
        schedulers:
        - slurm
    test_dcv.py::test_dcv_with_remote_access:
      dimensions:
      - instances:
        - c5.xlarge
        oss:
        - centos7
        regions:
        - ap-southeast-2
        schedulers:
        - slurm

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The tests add debug mode and restart cw agent. With a new version, the cw agent does not give complete output right after the agent restart. Therefore, this commit adds 10 seconds sleep after the agent restart

Signed-off-by: Hanwen <[email protected]>
@hanwen-pcluste hanwen-pcluste requested review from a team as code owners January 12, 2024 13:15
@hanwen-pcluste hanwen-pcluste added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1dc3af) 90.18% compared to head (d9f32ea) 90.18%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6008   +/-   ##
========================================
  Coverage    90.18%   90.18%           
========================================
  Files          180      180           
  Lines        15780    15780           
========================================
  Hits         14231    14231           
  Misses        1549     1549           
Flag Coverage Δ
unittests 90.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanwen-pcluste hanwen-pcluste merged commit a89a70b into aws:develop Jan 12, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants