From 9e53750d8d11bdedacfc38067206cad760dbb6d7 Mon Sep 17 00:00:00 2001 From: Andy Jewell Date: Fri, 5 Sep 2025 19:20:23 -0400 Subject: [PATCH 1/3] chore: bump mpl to allow nightly build --- mpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mpl b/mpl index dc1678ab7..2c575232d 160000 --- a/mpl +++ b/mpl @@ -1 +1 @@ -Subproject commit dc1678ab78948bee223f029df36b9f5d2cb0276d +Subproject commit 2c575232dd97fedcbb84232c8fb75e82e8483734 From bf1770b8f726a8769999fb90417e2a1fa78ce555 Mon Sep 17 00:00:00 2001 From: Andy Jewell Date: Mon, 8 Sep 2025 13:23:34 -0400 Subject: [PATCH 2/3] chore: Add go to smithy dependencies --- .../action.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/actions/install_smithy_dafny_codegen_dependencies/action.yml b/.github/actions/install_smithy_dafny_codegen_dependencies/action.yml index 579234e2e..75121a166 100644 --- a/.github/actions/install_smithy_dafny_codegen_dependencies/action.yml +++ b/.github/actions/install_smithy_dafny_codegen_dependencies/action.yml @@ -30,6 +30,16 @@ runs: python -m pip install --upgrade black python -m pip install --upgrade docformatter + - name: Install Go + uses: actions/setup-go@v2 + with: + go-version: "1.23" + + - name: Install Go imports + shell: bash + run: | + go install golang.org/x/tools/cmd/goimports@latest + # Without this the if-dafny-at-least command includes "Downloading ..." output - name: Arbitrary makefile target to force downloading Gradle shell: bash From 4a022dbe4ada75bda24fa7a2c86dd320fa8c35a2 Mon Sep 17 00:00:00 2001 From: Andy Jewell Date: Mon, 8 Sep 2025 13:52:35 -0400 Subject: [PATCH 3/3] dont double install go --- .../action.yml | 2 +- .../dafny_interop_library_go_tests.yml | 4 --- .github/workflows/go-release.yml | 9 ------- .github/workflows/library_codegen.yml | 4 --- .github/workflows/library_go_tests.yml | 4 --- .../library_interop_keyring_test_vectors.yml | 18 ------------- .../library_interop_mkp_test_vectors.yml | 27 ------------------- .github/workflows/library_rust_tests.yml | 6 ----- 8 files changed, 1 insertion(+), 73 deletions(-) diff --git a/.github/actions/install_smithy_dafny_codegen_dependencies/action.yml b/.github/actions/install_smithy_dafny_codegen_dependencies/action.yml index 75121a166..d7900e05f 100644 --- a/.github/actions/install_smithy_dafny_codegen_dependencies/action.yml +++ b/.github/actions/install_smithy_dafny_codegen_dependencies/action.yml @@ -31,7 +31,7 @@ runs: python -m pip install --upgrade docformatter - name: Install Go - uses: actions/setup-go@v2 + uses: actions/setup-go@v5 with: go-version: "1.23" diff --git a/.github/workflows/dafny_interop_library_go_tests.yml b/.github/workflows/dafny_interop_library_go_tests.yml index a8014d440..4ffb89fd4 100644 --- a/.github/workflows/dafny_interop_library_go_tests.yml +++ b/.github/workflows/dafny_interop_library_go_tests.yml @@ -76,10 +76,6 @@ jobs: with: go-version: ${{ matrix.go-version }} - - name: Install Go imports - run: | - go install golang.org/x/tools/cmd/goimports@latest - - name: Compile MPL with Dafny ${{inputs.mpl-dafny}} shell: bash working-directory: mpl/TestVectorsAwsCryptographicMaterialProviders diff --git a/.github/workflows/go-release.yml b/.github/workflows/go-release.yml index 3ed7b74aa..2d00a874c 100644 --- a/.github/workflows/go-release.yml +++ b/.github/workflows/go-release.yml @@ -51,15 +51,6 @@ jobs: with: dafny-version: ${{ needs.get-dafny-version.outputs.version }} - - name: Install Go - uses: actions/setup-go@v5 - with: - go-version: "1.23" - - - name: Install Go imports - run: | - go install golang.org/x/tools/cmd/goimports@latest - - name: Install Smithy-Dafny codegen dependencies uses: ./.github/actions/install_smithy_dafny_codegen_dependencies diff --git a/.github/workflows/library_codegen.yml b/.github/workflows/library_codegen.yml index 2bbce0ff2..6ecd90fc0 100644 --- a/.github/workflows/library_codegen.yml +++ b/.github/workflows/library_codegen.yml @@ -68,10 +68,6 @@ jobs: with: go-version: ${{ matrix.go-version }} - - name: Install Go imports - run: | - go install golang.org/x/tools/cmd/goimports@latest - - name: Install Smithy-Dafny codegen dependencies uses: ./.github/actions/install_smithy_dafny_codegen_dependencies diff --git a/.github/workflows/library_go_tests.yml b/.github/workflows/library_go_tests.yml index 8c77d12de..bb821f2eb 100644 --- a/.github/workflows/library_go_tests.yml +++ b/.github/workflows/library_go_tests.yml @@ -67,10 +67,6 @@ jobs: with: go-version: ${{ matrix.go-version }} - - name: Install Go imports - run: | - go install golang.org/x/tools/cmd/goimports@latest - - name: Compile ${{ matrix.library }} implementation shell: bash working-directory: ${{ matrix.library }} diff --git a/.github/workflows/library_interop_keyring_test_vectors.yml b/.github/workflows/library_interop_keyring_test_vectors.yml index a1590c10d..ce41dedd1 100644 --- a/.github/workflows/library_interop_keyring_test_vectors.yml +++ b/.github/workflows/library_interop_keyring_test_vectors.yml @@ -163,15 +163,6 @@ jobs: with: components: rustfmt - - name: Setup Go - uses: actions/setup-go@v5 - with: - go-version: "1.23" - - - name: Install Go imports - run: | - go install golang.org/x/tools/cmd/goimports@latest - - name: Setup NASM for Windows in Rust (aws-lc-sys) if: matrix.language == 'rust' && matrix.os == 'windows-latest' uses: ilammy/setup-nasm@v1 @@ -449,15 +440,6 @@ jobs: with: components: rustfmt - - name: Setup Go - uses: actions/setup-go@v5 - with: - go-version: "1.23" - - - name: Install Go imports - run: | - go install golang.org/x/tools/cmd/goimports@latest - - name: Setup NASM for Windows in Rust (aws-lc-sys) if: matrix.decrypting_language == 'rust' && matrix.os == 'windows-latest' uses: ilammy/setup-nasm@v1 diff --git a/.github/workflows/library_interop_mkp_test_vectors.yml b/.github/workflows/library_interop_mkp_test_vectors.yml index 52e841d76..77b7274f9 100644 --- a/.github/workflows/library_interop_mkp_test_vectors.yml +++ b/.github/workflows/library_interop_mkp_test_vectors.yml @@ -103,15 +103,6 @@ jobs: with: components: rustfmt - - name: Setup Go - uses: actions/setup-go@v5 - with: - go-version: "1.23" - - - name: Install Go imports - run: | - go install golang.org/x/tools/cmd/goimports@latest - - name: Setup NASM for Windows in Rust (aws-lc-sys) if: matrix.language == 'rust' && matrix.os == 'windows-latest' uses: ilammy/setup-nasm@v1 @@ -304,15 +295,6 @@ jobs: with: components: rustfmt - - name: Setup Go - uses: actions/setup-go@v5 - with: - go-version: "1.23" - - - name: Install Go imports - run: | - go install golang.org/x/tools/cmd/goimports@latest - - name: Setup NASM for Windows in Rust (aws-lc-sys) if: matrix.decrypting_language == 'rust' && matrix.os == 'windows-latest' uses: ilammy/setup-nasm@v1 @@ -737,15 +719,6 @@ jobs: with: components: rustfmt - - name: Setup Go - uses: actions/setup-go@v5 - with: - go-version: "1.23" - - - name: Install Go imports - run: | - go install golang.org/x/tools/cmd/goimports@latest - - name: Setup NASM for Windows in Rust (aws-lc-sys) if: matrix.decrypting_language == 'rust' && matrix.os == 'windows-latest' uses: ilammy/setup-nasm@v1 diff --git a/.github/workflows/library_rust_tests.yml b/.github/workflows/library_rust_tests.yml index 93e914835..6ac43916c 100644 --- a/.github/workflows/library_rust_tests.yml +++ b/.github/workflows/library_rust_tests.yml @@ -68,12 +68,6 @@ jobs: if: matrix.os == 'windows-latest' uses: ilammy/setup-nasm@v1 - # Go is needed for aws-lc-FIPS - - name: Install Go - uses: actions/setup-go@v5 - with: - go-version: ">=1.18" - - name: Install Smithy-Dafny codegen dependencies uses: ./.github/actions/install_smithy_dafny_codegen_dependencies