Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-build-isolation to make-bundle script #8038

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

kyleknap
Copy link
Contributor

This will ensure we strictly pull down the sdist and not try into install any other build dependencies (e.g. Cython) as part of downloading our main runtime dependencies.

This will ensure we strictly pull down the sdist and not try into
install any other build dependencies (e.g. Cython) as part of
downloading our main runtime dependencies.
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #8038 (b788201) into develop (4153da2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #8038   +/-   ##
=======================================
  Coverage     0.08%   0.08%           
=======================================
  Files          208     208           
  Lines        16539   16537    -2     
=======================================
  Hits            14      14           
+ Misses       16525   16523    -2     

see 2 files with indirect coverage changes

@kyleknap kyleknap merged commit dd3b592 into aws:develop Jul 17, 2023
@kyleknap kyleknap deleted the no-build-isolation-bundle branch July 17, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants