chore(cli): fix nested stack integ test collision

[iliapolo]

Commit Message

chore(cli): fix nested stack integ test collision (#7846)

The StackWithNestedStackUsingParameters in our integ test was for some reason passing a hardcoded parameter value to the nested stack instead of using the parameter value from the parent stack. In addition to not actually testing that parameters are passable between the parent and the child, it caused a collision with parallel tests because the topic name is provided was not unique.

This PR simply passes the parent stack parameter to the nested stack, the value of the parent stack param is already unique because it prepends the stack prefix.

In addition, many tests were using parameters like so:

new sns.Topic(this, 'TopicParameter', {
  topicName: new cdk.CfnParameter(this, 'TopicNameParam')
});

instead of:

new sns.Topic(this, 'TopicParameter', {
  topicName: new cdk.CfnParameter(this, 'TopicNameParam').valueAsString
});

The topicName property expects a string, not a CfnParameter. Since our tests are in javascript, it "compiled". But migrating this to typescript would actually result in a proper compilation error.

Strangely enough, both of these synthesize to the same thing:

Parameters:
  MyTopicParam:
    Type: String
Resources:
  MyTopic86869434:
    Type: AWS::SNS::Topic
    Properties:
      TopicName:
        Ref: MyTopicParam

This is because CfnParameter resolves to its value getter:

public resolve(_context: IResolveContext): any {
  return this.value;
}

End Commit Message

Regarding the valueAsString quirk, I changed it since i think the original commit was just an oversight that happened to work. Our docs all refer to using valueAs methods when defining parameters.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: e1c6239
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 06b8a54
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 2e0b433
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).