fix(ecs): update minHealthyPercent validation for ec2service #7814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piradeepk
previously requested changes
May 5, 2020
Contributor
piradeepk
left a comment
piradeepk
left a comment
There was a problem hiding this comment.
Thanks @iamhopaul123! This looks great overall, but had a couple minor comments.
piradeepk
approved these changes
May 5, 2020
Contributor
piradeepk
left a comment
piradeepk
left a comment
There was a problem hiding this comment.
Ship it! 💯 Looks great! Thanks @iamhopaul123!
Contributor
|
@iamhopaul123 can you update the description and describe hte previous behaviour as well as the new behaviour. |
iamhopaul123
removed
the
pr/do-not-merge
piradeepk
added
pr/do-not-merge
piradeepk
changed the title
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SoManyHs
approved these changes
May 5, 2020
| }, | ||
|
|
||
| 'errors if daemon and minimum not 0'(test: Test) { | ||
| 'errors if minimum not less than maximum'(test: Test) { |
iamhopaul123
added
pr/do-not-merge
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
karupanerura
pushed a commit
to karupanerura/aws-cdk
that referenced
this pull request
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unnecessary validation for "minHealthyPercent must be 0 when daemon strategy is set". Additionally, add validation for "minHealthyPercent must less than maxHealthyPercent".
Previously, the Ec2Service will throw an exception when the daemon strategy is used and a non-zero minHealthyPercent is defined. Users will now be allowed to define a minHealthyPercent of greater than zero.
Fixes #7396
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license