Skip to content

Conversation

@aws-cdk-automation
Copy link
Collaborator

see CHANGELOG

rix0rrr and others added 30 commits April 30, 2020 16:45
`MathExpression`s without submetrics (like for example, `INSIGHT_RULE_METRIC`) will end up without a `period`, which is not allowed.

Add a `period` field to the schema (it's not in the upstream schema
yet), and render it out when submetrics are missing.

Fixes #7155.
A lot of our examples still used the TypeScript `import` = `require` style.
This changes them to the standard ES6-style imports,
which we now enforce in our code.

Fixes #7554
This commit adds support for CodeBuild Artifacts to have names
controlled by a buildspec file, allowing the use of shell scripting to
sensibly name artifacts in CodeBuild projects generated from the CDK.
The previosuly required field `name` in `S3ArtifactsProps` is now optional,
and not providing it will set the `overrideArtifactName` on the underlying L1 to `true`.

Fixes #5955
Bumps [jest](https://github.com/facebook/jest) from 25.5.2 to 25.5.3.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md)
- [Commits](jestjs/jest@v25.5.2...v25.5.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.666.0 to 2.667.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.666.0...v2.667.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
- Currently `UserPool()` not support props of `signInType`.
- We able to create authorization on AppSync without any props.

Closes #7728
Two reasons:

* The `CDK_HOME` variable wasn't being consistently honored.
* Failing to write a cache file was a fatal error.

Rectify both of these issues.

Fixes #7530.
…dler

* feat(lambda-nodejs): use docker instead of npm package for parcel-bundler

* require version ^1 of parcel-bundler in Dockerfile

Co-Authored-By: Jonathan Goldwasser <[email protected]>

* update README: docker requirement

* comment in Dockerfile, make node version a build ARG

* add test for when docker not installed

* add optional nodeDockerTag to props

* Expose nodeDockerTag in NodejsFunctionProps and pass it to the Builder

* cdk-build pre

* chore(lambda-nodejs): remove dockerd pre directive

* add missing closing parenthesis

* fix linter errors

* fix linter error

* start docker daemon inside the container

* Update buildspec.yaml

* Fix docker location.

* Update buildspec.yaml

Co-authored-by: Jonathan Goldwasser <[email protected]>
Co-authored-by: Elad Ben-Israel <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
According to the [document](https://docs.aws.amazon.com/eks/latest/userguide/eks-optimized-ami.html), the path should be /**aws/service/eks/optimized-ami/1.15/amazon-linux-2/recommended/image_id**

Also fixes #6891
Fold the "assets" module, which includes the `Staging` construct that takes care of staging asset files into the cloud assembly during synthesis into "core". This is in order to allow implementing custom resources that leverage assets throughout the framework.

NOTE: since interfaces in @aws-cdk/assets are used as based types for stable APIs, we are unable to fully deprecate this module within the codebase, so these types are left in tact and a compatibility layer was added.

A subsequent commit will add a mini-framework for custom resources that leverages this capability.
When swallowing errors while writing the cache file, we should also
gracefully handle a read-only file system error (`EROFS`).
Prior to April 16, 2020, `AmazonEKSServicePolicy` was required for EKS cluster IAM role. With the new `AWSServiceRoleForAmazonEKS` service-linked role, that policy is no longer required.

This PR removes the `AmazonEKSServicePolicy` from the cluster role.

Closes #7634
…rcel-bundler" (#7738)

This reverts commit 55c4d0b.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.667.0 to 2.668.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.667.0...v2.668.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Users cannot go through our current contribution guide and successfully install the repo due to the `nock` dependency, which now needs a minimum of Node 10.13.0.

Closes #7671
Bumps [jest](https://github.com/facebook/jest) from 25.5.3 to 25.5.4.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md)
- [Commits](jestjs/jest@v25.5.3...v25.5.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Creating fargate profile without specifying `subnetSelection` will require extra iam policy to allow the iam role to describe subnets and route tables to select private subnets.  This PR adds the required `ec2:DescribeRouteTables` for the cluster creation role.

Closes #7614
Noticed this while massively updating integ test expectations for #7409.

Seems like lots of expectation files were modified "by hand". Ensures cleaner
diffs from now on.

Methodology:
* Comment out https://github.com/aws/aws-cdk/blob/d1b3b750cec3c514df6690e8baeffa7e9b260500/tools/cdk-integ-tools/bin/cdk-integ.ts#L38-L40
* `yarn lerna run integ --scope @aws-cdk/*`
Add a new imageScanOnPush property for the new repository creation.

Fix #7471
Correctly handle the default for `prefix`. An empty string now maps to the domain
root. Also add a `mapRoot` method.

Closes #7590

BREAKING CHANGE: `mapSubDomain()` called with an empty string for `prefix` now
maps to the domain root.
If an AppSync API is configured with the API key authorization mode,
then export it so it can be consumed as a stack output.

Signed-off-by: Duarte Nunes <[email protected]>

Co-authored-by: Mitchell Valine <[email protected]>
Added 'kms:Decrypt' action to `grantSendMessages`

Fixes: #6609
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Install only a single instance of the spot termination handler helm chart, even if there are multiple capacities or ASGs the use spot instances.

Fixes #7136
Fixes #7524
Selecting by `subnetGroupName` in a looked up VPC may produce 0 subnets
on the first run of the app, if the actual lookup hasn't been performed
yet.

Rather than throwing an exception (which will fail the execution
outright and never even get to perform the lookup), add a construct
error. On the next run the lookup will have been performed and
the validation will no longer fail.

Fixes #7580.
Route all traffic by default (not just TPC), and
give the user an opportunity to customize.

Fixes #7459.
#7731)

Stacks only end up in `REVIEW_IN_PROGRESS` state when they have never
been deployed by executing a changeset. It exists, but has no resources or a template.

Users can end up in this state if a changeset takes too long to deploy or if
the `--no-execute` flag is used the first time a stack is deployed. There are likely other
scenarios.

If a `cdk deploy` bails and a changeset finishes creation but does not get executed, a stack
will have `REVIEW_IN_PROGRESS` as its status

Root cause:

We're trying to `update` a stack that was never deployed.
CloudFormation considers a stack ID with no template or resources to be a
stack that does not exist. When we try to set the `ChangeSetType` to `UPDATE`,
it results in a `ValidationException` from CloudFormation

Fix:

When a stack is in `REVIEW_IN_PROGRESS` state, ensure we set the `ChangeSetType` to `CREATE`

Closes #6674
Created the L2 construct for FSx for Lustre with the ability to create or import a file system and give access to it through Connections.
Elad Ben-Israel and others added 15 commits May 4, 2020 15:14
This commit folds the `CustomResource` and `NestedStack` types from `@aws-cdk/aws-cloudformation` into `@aws-cdk/core` in order to allow code in `core` and other lower layers to use capabilities such as nested stacks and custom resources.

This comes at a minor sacrifice to API fidelity: the provider's service token is for custom resources is now passed as a simple `string` instead of a strongly typed `ICustomResourceProvider`. But this is negligible for this type of resource given the high involvement users require to use it anyway. Additionally, the `NestedStack` class accepts a `notificationArns` as a `string[]` instead of an `sns.ITopic[]`. In both cases the API in `@aws-cdk/aws-cloudformation` (which is considered a stable module) remains unchanged with a compatibility layer added.

We took this opportunity to change the behavior of custom resources so that it won't pascal-case property names by default. This resolves #4896 and resolves #7035 and supersedes #7034.

The API in the aws-cloudformation module are still supported for backwards compatibility but marked as deprecated.
Co-authored by: Niranjan Jayakar <[email protected]>

closes #5301
Refactor `CustomRule` to an enum-like class and add a static property
`SINGLE_PAGE_APPLICATION_REDIRECT` that sets up a 200 rewrite for all
files to `index.html` except for the following file extensions: css,
gif, ico, jpg, js, png, txt, svg, woff, ttf, map, json, webmanifest.
Add a `terminationProtection` prop to `StackProps` to enable stack termination
protection.

This does not require extra IAM permission for existing CDK stacks
(`cloudformation:UpdateTerminationProtection`).

The logic to evaluate if we can skip deploy is now moved to a separate
function.

Closes #1682
order matters in this comparison so it's failing because of that.
When creating a vpc that contains no subnets, you can not add a vpn gateway
or vpn connections to the vpc while creating. This is all good.
But I'm later adding subnets and want to add a vpn connection, then
it is not possible, the vpnGateay boolean in IVpc is a read only boolean
and is set to false and there's no way to change that. This commit adds
the method enableVpnGateway to later allow adding vpn connections when
startinh with a vpc with no subnets.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Principals can come with implicit conditions, which is useful for
representing principals that can't be expressed with a single field
in IAM.

However, you should not be allowed to use principals with mixed
conditions in a single statement, because IAM can't properly
express the implied OR there.

Fixes #3227.
Add a `LogQueryWidget` to generate a dashboard widget
showing the results of a query from Logs Insights.
This was a missing feature which is available in
the console.

closes #3681
Gateway endpoints can't be added to a VPC that doesn't have private
subnets.

Unless indicated otherwise, make the gateway endpoints routable from all
subnets. It'll only be routable from inside the VPC anyway (since
it will have a private IP address).

Fixes #7619.
@nija-at nija-at self-assigned this May 5, 2020
@nija-at nija-at added the pr/no-squash This PR should be merged instead of squash-merging it label May 5, 2020
@nija-at nija-at requested a review from a team May 5, 2020 14:16
@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8a15096
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 30a08b8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 5, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e4709de into release May 5, 2020
@mergify mergify bot deleted the bump/1.37.0 branch May 5, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-squash This PR should be merged instead of squash-merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.