chore(cli): run npm unit tests when testing javascript init templates #7665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Apr 29, 2020
shivlaks
approved these changes
Apr 29, 2020
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
Author
|
@Mergifyio refresh |
1 similar comment
Contributor
Author
|
@Mergifyio refresh |
Contributor
|
Command |
1 similar comment
Contributor
|
Command |
iliapolo
added a commit
that referenced
this pull request
Apr 29, 2020
…#7665) Added missing `npm run test` invocation to align with our typescript [test](https://github.com/aws/aws-cdk/blob/master/packages/aws-cdk/test/integ/init/test-typescript.sh#L27).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
chore(cli): run npm unit tests when testing javascript init templates (#7665 )
Added missing
npm run testinvocation to align with our typescript test.End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license