-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(spec2cdk): refactor to make it easier to extend #35950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d2c5653 to
a895ef9
Compare
The `spec2cdk` tool was originally written to generate every service submodule insularly. We want to now extend it to emit structures into a new shared submodule. In order to do that, this refactors the generator to have a more shared, mutable object-oriented design which will be easier to share state in. In addition, simplify the API around file name patterns, because they were being overly flexible and annoying to work with for no real benefit.
a895ef9 to
6d59543
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
The
spec2cdktool was originally written to generate every service submodule insularly.We want to now extend it to emit structures into a new shared submodule. In order to do that, this refactors the generator to have a more shared, mutable object-oriented design which will be easier to share state in.
The core of the change looks like this:
ServiceModule,ResourceModuleclasses, because they were adding no benefit over the genericModule.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license