Skip to content

Conversation

@dineshSajwan
Copy link
Contributor

Issue # (if applicable)

Reason for this change

The grantInvoke, grantInvokeRuntime, and grantInvokeRuntimeForUser methods in the BedrockAgentRuntime were only granting permissions to the runtime ARN itself, but not to its sub-resources. This caused permission issues when trying to invoke runtime endpoints from an AWS resource like lambda, as the actual invocation happens on sub-resources (e.g., arn:aws:bedrock-agentcore:region:account:runtime/runtime-id/*).

Description of changes

Updated the resourceArns parameter in three grant methods within runtime-base.ts:

Describe any new or updated permissions being added

The IAM permissions granted by these methods now include:

  • bedrock-agentcore:InvokeAgentRuntime on both the runtime ARN and its sub-resources
  • bedrock-agentcore:InvokeAgentRuntimeForUser on both the runtime ARN and its sub-resources

Description of how you validated changes

Manual and Integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 27, 2025 18:33
@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Oct 27, 2025
@dineshSajwan dineshSajwan marked this pull request as ready for review October 27, 2025 18:33
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation added the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Oct 27, 2025
@Abogical Abogical self-assigned this Oct 29, 2025
// Create a single runtime (similar to the working strands example)
const runtime = new agentcore.Runtime(stack, 'TestRuntime', {
runtimeName: 'integ_test_runtime',
runtimeName: 'integTest_runtime',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 24, 2025 16:31

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@dineshSajwan dineshSajwan changed the title feat(agentcore): update resources on grantInvokeXXX for runtime feat(bedrock-agentcore-alpha): update resources on grantInvokeXXX for runtime Nov 24, 2025
@mergify mergify bot dismissed Abogical’s stale review November 24, 2025 16:39

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 24, 2025
@alvazjor alvazjor self-assigned this Nov 25, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2025

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 1 hour 20 minutes 28 seconds in the queue, including 29 minutes 28 seconds waiting for CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 25, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5dad62f into aws:main Nov 25, 2025
17 of 18 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p2 pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants