-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(msk): support Express brokers #34741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
25b01ca
feat(msk): support Express Brokers
mazyu36 f95c010
wip
mazyu36 3851f70
update readme
mazyu36 ae768c8
wip
mazyu36 e01e65b
wip
mazyu36 1a958b8
add validation and snapshot test
mazyu36 2cc0f9c
fix
mazyu36 c2c11a1
Merge branch 'main' into feat/msk-express
mazyu36 dcea70d
Merge branch 'main' into feat/msk-express
mazyu36 2048b76
Update integ.cluster-express.ts
mazyu36 ab1180c
Update README.md
mazyu36 13272d5
Merge branch 'main' into feat/msk-express
mazyu36 dea8360
Merge branch 'main' into feat/msk-express
mazyu36 f2dc968
Merge branch 'main' into feat/msk-express
mazyu36 3d2d3a6
fix integ
mazyu36 88f278a
Merge branch 'main' into feat/msk-express
mazyu36 212ed71
Merge branch 'main' into feat/msk-express
mazyu36 70e0382
Merge branch 'main' into feat/msk-express
mazyu36 63e0669
Merge branch 'main' into feat/msk-express
mazyu36 a63d8cf
Merge branch 'main' into feat/msk-express
mazyu36 fe2e105
comments
mazyu36 4564190
Merge branch 'main' into feat/msk-express
mazyu36 9ee8d63
update
mazyu36 1ce4075
Merge branch 'main' into feat/msk-express
mergify[bot] be5a1f9
Merge branch 'main' into feat/msk-express
kumsmrit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we switch from using boolean to enum instead
readonly brokerType?: BrokerType;keeping it more future proof ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Added Enum.